[mlir] Use StringRef::consume_front (NFC)

[kazutakahirata]

No description provided.

[llvmbot]

@llvm/pr-subscribers-mlir-llvm

@llvm/pr-subscribers-mlir

Author: Kazu Hirata (kazutakahirata)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/139459.diff

1 Files Affected:

• (modified) mlir/lib/Target/LLVMIR/ModuleTranslation.cpp (+1-2)

diff --git a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
index ad4f65da9d7f5..1168b9f339904 100644
--- a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
+++ b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
@@ -296,8 +296,7 @@ translateDataLayout(DataLayoutSpecInterface attribute,
       return failure();
   }
   StringRef layoutSpec(llvmDataLayout);
-  if (layoutSpec.starts_with("-"))
-    layoutSpec = layoutSpec.drop_front();
+  layoutSpec.consume_front("-");
 
   return llvm::DataLayout(layoutSpec);
 }

[llvm-ci]

LLVM Buildbot has detected a new failure on builder mlir-nvidia running on mlir-nvidia while building mlir at step 7 "test-build-check-mlir-build-only-check-mlir".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/138/builds/12960

Here is the relevant piece of the build log for the reference

Step 7 (test-build-check-mlir-build-only-check-mlir) failure: test (failure)
******************** TEST 'MLIR :: Integration/GPU/CUDA/async.mlir' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt /vol/worker/mlir-nvidia/mlir-nvidia/llvm.src/mlir/test/Integration/GPU/CUDA/async.mlir  | /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt -gpu-kernel-outlining  | /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt -pass-pipeline='builtin.module(gpu.module(strip-debuginfo,convert-gpu-to-nvvm),nvvm-attach-target)'  | /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt -gpu-async-region -gpu-to-llvm -reconcile-unrealized-casts -gpu-module-to-binary="format=fatbin"  | /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt -async-to-async-runtime -async-runtime-ref-counting  | /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt -convert-async-to-llvm -convert-func-to-llvm -convert-arith-to-llvm -convert-cf-to-llvm -reconcile-unrealized-casts  | /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-runner    --shared-libs=/vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/lib/libmlir_cuda_runtime.so    --shared-libs=/vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/lib/libmlir_async_runtime.so    --shared-libs=/vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/lib/libmlir_runner_utils.so    --entry-point-result=void -O0  | /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/FileCheck /vol/worker/mlir-nvidia/mlir-nvidia/llvm.src/mlir/test/Integration/GPU/CUDA/async.mlir
# executed command: /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt /vol/worker/mlir-nvidia/mlir-nvidia/llvm.src/mlir/test/Integration/GPU/CUDA/async.mlir
# executed command: /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt -gpu-kernel-outlining
# executed command: /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt '-pass-pipeline=builtin.module(gpu.module(strip-debuginfo,convert-gpu-to-nvvm),nvvm-attach-target)'
# executed command: /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt -gpu-async-region -gpu-to-llvm -reconcile-unrealized-casts -gpu-module-to-binary=format=fatbin
# executed command: /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt -async-to-async-runtime -async-runtime-ref-counting
# executed command: /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt -convert-async-to-llvm -convert-func-to-llvm -convert-arith-to-llvm -convert-cf-to-llvm -reconcile-unrealized-casts
# executed command: /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-runner --shared-libs=/vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/lib/libmlir_cuda_runtime.so --shared-libs=/vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/lib/libmlir_async_runtime.so --shared-libs=/vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/lib/libmlir_runner_utils.so --entry-point-result=void -O0
# .---command stderr------------
# | 'cuStreamWaitEvent(stream, event, 0)' failed with 'CUDA_ERROR_CONTEXT_IS_DESTROYED'
# | 'cuEventDestroy(event)' failed with 'CUDA_ERROR_CONTEXT_IS_DESTROYED'
# | 'cuStreamWaitEvent(stream, event, 0)' failed with 'CUDA_ERROR_CONTEXT_IS_DESTROYED'
# | 'cuEventDestroy(event)' failed with 'CUDA_ERROR_CONTEXT_IS_DESTROYED'
# | 'cuStreamWaitEvent(stream, event, 0)' failed with 'CUDA_ERROR_CONTEXT_IS_DESTROYED'
# | 'cuStreamWaitEvent(stream, event, 0)' failed with 'CUDA_ERROR_CONTEXT_IS_DESTROYED'
# | 'cuEventDestroy(event)' failed with 'CUDA_ERROR_CONTEXT_IS_DESTROYED'
# | 'cuEventDestroy(event)' failed with 'CUDA_ERROR_CONTEXT_IS_DESTROYED'
# | 'cuEventSynchronize(event)' failed with 'CUDA_ERROR_CONTEXT_IS_DESTROYED'
# | 'cuEventDestroy(event)' failed with 'CUDA_ERROR_CONTEXT_IS_DESTROYED'
# `-----------------------------
# executed command: /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/FileCheck /vol/worker/mlir-nvidia/mlir-nvidia/llvm.src/mlir/test/Integration/GPU/CUDA/async.mlir
# .---command stderr------------
# | /vol/worker/mlir-nvidia/mlir-nvidia/llvm.src/mlir/test/Integration/GPU/CUDA/async.mlir:68:12: error: CHECK: expected string not found in input
# |  // CHECK: [84, 84]
# |            ^
# | <stdin>:1:1: note: scanning from here
# | Unranked Memref base@ = 0x56740ae30770 rank = 1 offset = 0 sizes = [2] strides = [1] data = 
# | ^
# | <stdin>:2:1: note: possible intended match here
# | [42, 42]
# | ^
# | 
# | Input file: <stdin>
# | Check file: /vol/worker/mlir-nvidia/mlir-nvidia/llvm.src/mlir/test/Integration/GPU/CUDA/async.mlir
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |             1: Unranked Memref base@ = 0x56740ae30770 rank = 1 offset = 0 sizes = [2] strides = [1] data =  
# | check:68'0     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
# |             2: [42, 42] 
# | check:68'0     ~~~~~~~~~
# | check:68'1     ?         possible intended match
...

[llvm-ci]

LLVM Buildbot has detected a new failure on builder premerge-monolithic-windows running on premerge-windows-1 while building mlir at step 5 "clean-build-dir".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/35/builds/9993

Here is the relevant piece of the build log for the reference

Step 5 (clean-build-dir) failure: Delete failed. (failure)
Step 8 (test-build-unified-tree-check-all) failure: test (failure)
...
[643/1496] Building CXX object tools\clang\unittests\Format\CMakeFiles\FormatTests.dir\UsingDeclarationsSorterTest.cpp.obj
[644/1496] Building CXX object tools\clang\unittests\Format\CMakeFiles\FormatTests.dir\NamespaceEndCommentsFixerTest.cpp.obj
[645/1496] Building CXX object tools\polly\unittests\Isl\CMakeFiles\IslTests.dir\IslTest.cpp.obj
[646/1496] Building CXX object tools\clang\unittests\Format\CMakeFiles\FormatTests.dir\MacroCallReconstructorTest.cpp.obj
[647/1496] Building CXX object tools\polly\unittests\Flatten\CMakeFiles\FlattenTests.dir\FlattenTest.cpp.obj
[648/1496] Building CXX object tools\clang\unittests\Format\CMakeFiles\FormatTests.dir\FormatTokenSourceTest.cpp.obj
[649/1496] Building CXX object tools\clang\unittests\Format\CMakeFiles\FormatTests.dir\ObjCPropertyAttributeOrderFixerTest.cpp.obj
[650/1496] Building CXX object tools\clang\unittests\Format\CMakeFiles\FormatTests.dir\MacroExpanderTest.cpp.obj
[651/1496] Building CXX object tools\clang\unittests\Format\CMakeFiles\FormatTests.dir\QualifierFixerTest.cpp.obj
[652/1496] Preparing lit tests
FAILED: utils/lit/CMakeFiles/prepare-check-lit 
cmd.exe /C "cd /D C:\ws\buildbot\premerge-monolithic-windows\build\utils\lit && C:\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe -E remove_directory C:/ws/buildbot/premerge-monolithic-windows/build/utils/lit/tests && C:\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe -E copy_directory C:/ws/buildbot/premerge-monolithic-windows/llvm-project/llvm/utils/lit/tests C:/ws/buildbot/premerge-monolithic-windows/build/utils/lit/tests && C:\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe -E copy C:/ws/buildbot/premerge-monolithic-windows/build/utils/lit/lit.site.cfg C:/ws/buildbot/premerge-monolithic-windows/build/utils/lit/tests"
Error removing directory "C:/ws/buildbot/premerge-monolithic-windows/build/utils/lit/tests".
[653/1496] Building CXX object tools\polly\unittests\ScheduleOptimizer\CMakeFiles\ScheduleOptimizerTests.dir\ScheduleTreeTransformTest.cpp.obj
[654/1496] Building CXX object tools\clang\unittests\Format\CMakeFiles\FormatTests.dir\TokenAnnotatorTest.cpp.obj
[655/1496] Linking CXX executable tools\clang\unittests\Basic\BasicTests.exe
[656/1496] Building CXX object tools\polly\unittests\Support\CMakeFiles\ISLToolsTests.dir\ISLTools.cpp.obj
[657/1496] Building CXX object unittests\ADT\CMakeFiles\ADTTests.dir\CountCopyAndMove.cpp.obj
[658/1496] Building CXX object tools\polly\unittests\DeLICM\CMakeFiles\DeLICMTests.dir\DeLICMTest.cpp.obj
[659/1496] Building CXX object unittests\ADT\CMakeFiles\ADTTests.dir\AnyTest.cpp.obj
[660/1496] Building CXX object unittests\ADT\CMakeFiles\ADTTests.dir\APFixedPointTest.cpp.obj
[661/1496] Building CXX object tools\clang\unittests\Interpreter\CMakeFiles\ClangReplInterpreterTests.dir\IncrementalCompilerBuilderTest.cpp.obj
[662/1496] Building CXX object tools\polly\unittests\ScopPassManager\CMakeFiles\ScopPassManagerTests.dir\PassManagerTest.cpp.obj
[663/1496] Building CXX object unittests\ADT\CMakeFiles\ADTTests.dir\ArrayRefTest.cpp.obj
[664/1496] Building CXX object unittests\ADT\CMakeFiles\ADTTests.dir\BitFieldsTest.cpp.obj
[665/1496] Building CXX object unittests\ADT\CMakeFiles\ADTTests.dir\APSIntTest.cpp.obj
[666/1496] Building CXX object unittests\ADT\CMakeFiles\ADTTests.dir\BitmaskEnumTest.cpp.obj
[667/1496] Building CXX object unittests\ADT\CMakeFiles\ADTTests.dir\BumpPtrListTest.cpp.obj
[668/1496] Building CXX object unittests\ADT\CMakeFiles\ADTTests.dir\BitTest.cpp.obj
[669/1496] Building CXX object unittests\ADT\CMakeFiles\ADTTests.dir\BitVectorTest.cpp.obj
[670/1496] Building CXX object unittests\ADT\CMakeFiles\ADTTests.dir\APIntTest.cpp.obj
[671/1496] Building CXX object unittests\ADT\CMakeFiles\ADTTests.dir\BreadthFirstIteratorTest.cpp.obj
[672/1496] Building CXX object unittests\ADT\CMakeFiles\ADTTests.dir\CoalescingBitVectorTest.cpp.obj
[673/1496] Building CXX object unittests\ADT\CMakeFiles\ADTTests.dir\ConcurrentHashtableTest.cpp.obj
[674/1496] Building CXX object unittests\ADT\CMakeFiles\ADTTests.dir\APFloatTest.cpp.obj
[675/1496] Building CXX object unittests\ADT\CMakeFiles\ADTTests.dir\DAGDeltaAlgorithmTest.cpp.obj
[676/1496] Building CXX object unittests\ADT\CMakeFiles\ADTTests.dir\CombinationGeneratorTest.cpp.obj
[677/1496] Building CXX object tools\clang\unittests\Interpreter\CMakeFiles\ClangReplInterpreterTests.dir\InterpreterExtensionsTest.cpp.obj
[678/1496] Building CXX object tools\clang\unittests\Interpreter\CMakeFiles\ClangReplInterpreterTests.dir\InterpreterTest.cpp.obj
[679/1496] Building CXX object tools\clang\unittests\Interpreter\CMakeFiles\ClangReplInterpreterTests.dir\CodeCompletionTest.cpp.obj
[680/1496] Building CXX object tools\clang\unittests\Interpreter\CMakeFiles\ClangReplInterpreterTests.dir\IncrementalProcessingTest.cpp.obj
[681/1496] Linking CXX executable tools\polly\unittests\Flatten\FlattenTests.exe
[682/1496] Linking CXX executable tools\polly\unittests\Isl\IslTests.exe
[683/1496] Linking CXX executable tools\clang\unittests\AllClangUnitTests.exe
ninja: build stopped: subcommand failed.