Skip to content

[AMDGPU] si-peephole-sdwa: Fix cndmask vcc use for wave32 #139541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 14, 2025
Merged

[AMDGPU] si-peephole-sdwa: Fix cndmask vcc use for wave32 #139541

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d32f060
[AMDGPU] Add tests that demonstrates si-peephole-sdwa failure on V_CN…
frederik-h May 12, 2025
85e8efa
[AMDGPU] si-peephole-sdwa: Fix cndmask vcc use for wave32
frederik-h May 12, 2025
dc740ce
Clean up test
frederik-h May 12, 2025
6f24263
Update llvm/test/CodeGen/AMDGPU/sdwa-peephole-cndmask-fail.ll
frederik-h May 12, 2025
4b52ec5
Add mir test
frederik-h May 12, 2025
b5f3df9
Update llvm/test/CodeGen/AMDGPU/sdwa-peephole-cndmask-wave32.mir
frederik-h May 13, 2025
d68738f
Update llvm/test/CodeGen/AMDGPU/sdwa-peephole-cndmask-fail.ll
frederik-h May 13, 2025
5b1a158
Simplify and correct ll test
frederik-h May 13, 2025
3a1e535
Update test expectations
frederik-h May 13, 2025
245792d
Update mir test
frederik-h May 13, 2025
2416eff
Merge remote-tracking branch 'upstream/main' into peephole-sdwa-cndma…
frederik-h May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update llvm/test/CodeGen/AMDGPU/sdwa-peephole-cndmask-wave32.mir 
Co-authored-by: Matt Arsenault <[email protected]>
  • Loading branch information
@frederik-h @arsenm
frederik-h and arsenm authored May 13, 2025
commit b5f3df9df196507cdea8c2e22f817e6138cf0669
6 changes: 3 additions & 3 deletions llvm/test/CodeGen/AMDGPU/sdwa-peephole-cndmask-wave32.mir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,9 +282,9 @@ body: |
successors: %bb.1(0x40000000), %bb.2(0x40000000)
liveins: $vgpr0, $sgpr8_sgpr9

%0:sgpr_64(p4) = COPY $sgpr8_sgpr9
%1:vgpr_32(s32) = COPY $vgpr0
%2:sreg_64_xexec = S_LOAD_DWORDX2_IMM %0(p4), 0, 0
%0:sgpr_64 = COPY $sgpr8_sgpr9
%1:vgpr_32 = COPY $vgpr0
%2:sreg_64_xexec = S_LOAD_DWORDX2_IMM %0, 0, 0
S_BITCMP1_B32 %2.sub1, 0, implicit-def $scc
%3:sreg_32_xm0_xexec = S_CSELECT_B32 -1, 0, implicit $scc
%4:vgpr_32 = V_MOV_B32_e32 0, implicit $exec
Expand Down
Loading