[llvm][mlir][NFC] Fix typos in comments and test descriptions #139688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-llvm-analysis @llvm/pr-subscribers-mlir Author: Wang Qiang (ReVe1uv) ChangesThis patch fixes several typographical errors in comments and test files:
These changes are non-functional and intended to improve readability and documentation accuracy. Full diff: https://github.com/llvm/llvm-project/pull/139688.diff 3 Files Affected:
diff --git a/llvm/test/Analysis/DependenceAnalysis/SimpleSIVNoValidityCheckFixedSize.ll b/llvm/test/Analysis/DependenceAnalysis/SimpleSIVNoValidityCheckFixedSize.ll
index c4948ebf9854b..2638bb045de3d 100644
--- a/llvm/test/Analysis/DependenceAnalysis/SimpleSIVNoValidityCheckFixedSize.ll
+++ b/llvm/test/Analysis/DependenceAnalysis/SimpleSIVNoValidityCheckFixedSize.ll
@@ -1,7 +1,7 @@
; NOTE: Assertions have been autogenerated by utils/update_analyze_test_checks.py UTC_ARGS: --version 5
; RUN: opt < %s -disable-output -passes="print<da>" 2>&1 | FileCheck %s
-; Note: exact results can be achived even if
+; Note: exact results can be achieved even if
; "-da-disable-delinearization-checks" is not used
;; #define N 1024
diff --git a/llvm/test/Object/archive-update.test b/llvm/test/Object/archive-update.test
index e152da5705c16..ffe81fd786175 100644
--- a/llvm/test/Object/archive-update.test
+++ b/llvm/test/Object/archive-update.test
@@ -17,7 +17,7 @@ RUN: touch -m -t 200001010000 %t/tmp.older/evenlen || sleep 2.1
RUN: echo newer > %t/tmp.newer/evenlen
RUN: touch %t/tmp.newer/evenlen
-Create an achive with the newest file
+Create an achieve with the newest file
RUN: llvm-ar rU %t/tmp.a %t/tmp.newer/evenlen
RUN: llvm-ar p %t/tmp.a | FileCheck --check-prefix=NEWER %s
diff --git a/mlir/lib/Dialect/XeGPU/Transforms/XeGPUSubgroupDistribute.cpp b/mlir/lib/Dialect/XeGPU/Transforms/XeGPUSubgroupDistribute.cpp
index acdbe7be1358b..992700524146a 100644
--- a/mlir/lib/Dialect/XeGPU/Transforms/XeGPUSubgroupDistribute.cpp
+++ b/mlir/lib/Dialect/XeGPU/Transforms/XeGPUSubgroupDistribute.cpp
@@ -835,7 +835,7 @@ LogicalResult LayoutAttrAssignment::run() {
/// TODO: Implement the layout conflict resolution. This must ensure mainly two
/// things:
/// 1) Is a given layout supported by the op? (need to query the target
-/// HW info). Otherwise can we achive this layout using a layout conversion?
+/// HW info). Otherwise can we achieve this layout using a layout conversion?
/// 2) Do all the operands have the required layout? If not, can it
/// be resolved using a layout conversion?
LogicalResult LayoutAttrAssignment::resolveConflicts() { return success(); }
|
|
@llvm/pr-subscribers-llvm-binary-utilities Author: Wang Qiang (ReVe1uv) ChangesThis patch fixes several typographical errors in comments and test files:
These changes are non-functional and intended to improve readability and documentation accuracy. Full diff: https://github.com/llvm/llvm-project/pull/139688.diff 3 Files Affected:
diff --git a/llvm/test/Analysis/DependenceAnalysis/SimpleSIVNoValidityCheckFixedSize.ll b/llvm/test/Analysis/DependenceAnalysis/SimpleSIVNoValidityCheckFixedSize.ll
index c4948ebf9854b..2638bb045de3d 100644
--- a/llvm/test/Analysis/DependenceAnalysis/SimpleSIVNoValidityCheckFixedSize.ll
+++ b/llvm/test/Analysis/DependenceAnalysis/SimpleSIVNoValidityCheckFixedSize.ll
@@ -1,7 +1,7 @@
; NOTE: Assertions have been autogenerated by utils/update_analyze_test_checks.py UTC_ARGS: --version 5
; RUN: opt < %s -disable-output -passes="print<da>" 2>&1 | FileCheck %s
-; Note: exact results can be achived even if
+; Note: exact results can be achieved even if
; "-da-disable-delinearization-checks" is not used
;; #define N 1024
diff --git a/llvm/test/Object/archive-update.test b/llvm/test/Object/archive-update.test
index e152da5705c16..ffe81fd786175 100644
--- a/llvm/test/Object/archive-update.test
+++ b/llvm/test/Object/archive-update.test
@@ -17,7 +17,7 @@ RUN: touch -m -t 200001010000 %t/tmp.older/evenlen || sleep 2.1
RUN: echo newer > %t/tmp.newer/evenlen
RUN: touch %t/tmp.newer/evenlen
-Create an achive with the newest file
+Create an achieve with the newest file
RUN: llvm-ar rU %t/tmp.a %t/tmp.newer/evenlen
RUN: llvm-ar p %t/tmp.a | FileCheck --check-prefix=NEWER %s
diff --git a/mlir/lib/Dialect/XeGPU/Transforms/XeGPUSubgroupDistribute.cpp b/mlir/lib/Dialect/XeGPU/Transforms/XeGPUSubgroupDistribute.cpp
index acdbe7be1358b..992700524146a 100644
--- a/mlir/lib/Dialect/XeGPU/Transforms/XeGPUSubgroupDistribute.cpp
+++ b/mlir/lib/Dialect/XeGPU/Transforms/XeGPUSubgroupDistribute.cpp
@@ -835,7 +835,7 @@ LogicalResult LayoutAttrAssignment::run() {
/// TODO: Implement the layout conflict resolution. This must ensure mainly two
/// things:
/// 1) Is a given layout supported by the op? (need to query the target
-/// HW info). Otherwise can we achive this layout using a layout conversion?
+/// HW info). Otherwise can we achieve this layout using a layout conversion?
/// 2) Do all the operands have the required layout? If not, can it
/// be resolved using a layout conversion?
LogicalResult LayoutAttrAssignment::resolveConflicts() { return success(); }
|
jh7370
requested changes
May 13, 2025
This patch fixes several typographical errors in comments and test files: 1.Corrected "achive" to "archive" in archive-update.test. 2.Fixed "achive" to "achieve" in a comment in XeGPUSubgroupDistribute.cpp. 3.Corrected "achived" to "achieved" in a test note in SimpleSIVNoValidityCheckFixedSize.ll. These changes are non-functional and intended to improve readability and documentation accuracy. Signed-off-by: Kane Wang <[email protected]>
jh7370
approved these changes
May 13, 2025
Yes, that would be great. Thanks for offering to help with the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes several typographical errors in comments and test files:
These changes are non-functional and intended to improve readability and documentation accuracy.