[FuzzMutate] Prevent UB caused by parameter ABI attributes #139737
+55
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We make those cases unsupported as it happens now for functions accepting metadata or token types.
DataCorrupted
requested changes
May 13, 2025
| @@ -143,6 +143,9 @@ class InsertFunctionStrategy : public IRMutationStrategy { | |||
|
|
|||
| using IRMutationStrategy::mutate; | |||
| void mutate(BasicBlock &BB, RandomIRBuilder &IB) override; | |||
|
|
|||
| private: | |||
| bool isUnsupportedFunction(Function *F); | |||
There was a problem hiding this comment.
Nit: This function does not concern InsertFunctionStrategy a lot. Maybe better to declare it in IRMutator.cpp as static bool isUnsupportedFunction. Also better to comment all unsupported reason on top of the definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the IRMutator from incorrectly calling functions that have ABI attributes, otherwise the mutations introduce UB.