[OpenMP] Fix crash with invalid size expression

[AaronBallman]

We weren't correctly handling size expressions with errors before trying to get the type of the size expression.

No release note needed because support for 'stripe' was added to the current release.

Fixes #139433

[llvmbot]

@llvm/pr-subscribers-clang

Author: Aaron Ballman (AaronBallman)

Changes

We weren't correctly handling size expressions with errors before trying to get the type of the size expression.

No release note needed because support for 'stripe' was added to the current release.

Fixes #139433

---

Full diff: https://github.com/llvm/llvm-project/pull/139745.diff

2 Files Affected:

• (modified) clang/lib/Sema/SemaOpenMP.cpp (+4-1)
• (modified) clang/test/OpenMP/stripe_messages.cpp (+8)

diff --git a/clang/lib/Sema/SemaOpenMP.cpp b/clang/lib/Sema/SemaOpenMP.cpp
index be6ce97d838f3..d9a24adc64f1b 100644
--- a/clang/lib/Sema/SemaOpenMP.cpp
+++ b/clang/lib/Sema/SemaOpenMP.cpp
@@ -14551,7 +14551,10 @@ StmtResult SemaOpenMP::ActOnOpenMPStripeDirective(ArrayRef<OMPClause *> Clauses,
 
   const auto *SizesClause =
       OMPExecutableDirective::getSingleClause<OMPSizesClause>(Clauses);
-  if (!SizesClause || llvm::is_contained(SizesClause->getSizesRefs(), nullptr))
+  if (!SizesClause ||
+      llvm::any_of(SizesClause->getSizesRefs(), [](const Expr *SizeExpr) {
+        return !SizeExpr || SizeExpr->containsErrors();
+      }))
     return StmtError();
   unsigned NumLoops = SizesClause->getNumSizes();
 
diff --git a/clang/test/OpenMP/stripe_messages.cpp b/clang/test/OpenMP/stripe_messages.cpp
index d05b8566f11de..a7799ec53311e 100644
--- a/clang/test/OpenMP/stripe_messages.cpp
+++ b/clang/test/OpenMP/stripe_messages.cpp
@@ -161,3 +161,11 @@ void template_inst() {
   // expected-note@+1 {{in instantiation of function template specialization 'templated_func_type_dependent<int>' requested here}}
   templated_func_type_dependent<int>();
 }
+
+namespace GH139433 {
+void f() {
+#pragma omp stripe sizes(a)
+  for (int i = 0; i < 10; i++)
+    ;
+}
+} // namespace GH139433