Skip to content

[mlir] Use llvm::find (NFC) #139757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kazutakahirata
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented May 13, 2025

@llvm/pr-subscribers-mlir-vector
@llvm/pr-subscribers-mlir-linalg

@llvm/pr-subscribers-mlir-affine

Author: Kazu Hirata (kazutakahirata)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/139757.diff

4 Files Affected:

  • (modified) mlir/lib/Dialect/Affine/Transforms/RaiseMemrefDialect.cpp (+1-1)
  • (modified) mlir/lib/Dialect/Linalg/Transforms/WinogradConv2D.cpp (+1-1)
  • (modified) mlir/lib/Dialect/Vector/Utils/VectorUtils.cpp (+1-2)
  • (modified) mlir/test/lib/Dialect/Linalg/TestLinalgFusionTransforms.cpp (+1-2)
diff --git a/mlir/lib/Dialect/Affine/Transforms/RaiseMemrefDialect.cpp b/mlir/lib/Dialect/Affine/Transforms/RaiseMemrefDialect.cpp
index 491d2e03c36bc..3fc2664aefdfb 100644
--- a/mlir/lib/Dialect/Affine/Transforms/RaiseMemrefDialect.cpp
+++ b/mlir/lib/Dialect/Affine/Transforms/RaiseMemrefDialect.cpp
@@ -48,7 +48,7 @@ static std::optional<size_t>
 findInListOrAdd(Value value, llvm::SmallVectorImpl<Value> &dims,
                 function_ref<bool(Value)> isValidElement) {
 
-  Value *loopIV = std::find(dims.begin(), dims.end(), value);
+  Value *loopIV = llvm::find(dims, value);
   if (loopIV != dims.end()) {
     // We found an IV that already has an index, return that index.
     return {std::distance(dims.begin(), loopIV)};
diff --git a/mlir/lib/Dialect/Linalg/Transforms/WinogradConv2D.cpp b/mlir/lib/Dialect/Linalg/Transforms/WinogradConv2D.cpp
index f1059ddf5da2c..c6ebd3a53d981 100644
--- a/mlir/lib/Dialect/Linalg/Transforms/WinogradConv2D.cpp
+++ b/mlir/lib/Dialect/Linalg/Transforms/WinogradConv2D.cpp
@@ -960,7 +960,7 @@ winogradConv2DHelper(RewriterBase &rewriter, linalg::Conv2DNhwcFhwcOp convOp,
       F_2_3, F_4_3, F_2_5};
 
   TransformMapKeyTy key = {m, r};
-  auto it = std::find(validConfigs.begin(), validConfigs.end(), key);
+  auto it = llvm::find(validConfigs, key);
   // If we cannot find the constant transformation matrix, it means we do
   // not support this configuration yet.
   if (it == validConfigs.end())
diff --git a/mlir/lib/Dialect/Vector/Utils/VectorUtils.cpp b/mlir/lib/Dialect/Vector/Utils/VectorUtils.cpp
index 399e902af4062..d5dd6f2027be8 100644
--- a/mlir/lib/Dialect/Vector/Utils/VectorUtils.cpp
+++ b/mlir/lib/Dialect/Vector/Utils/VectorUtils.cpp
@@ -291,8 +291,7 @@ vector::createUnrollIterator(VectorType vType, int64_t targetRank) {
   // cannot be unrolled).
   auto shapeToUnroll = vType.getShape().drop_back(targetRank);
   auto scalableDimsToUnroll = vType.getScalableDims().drop_back(targetRank);
-  auto it =
-      std::find(scalableDimsToUnroll.begin(), scalableDimsToUnroll.end(), true);
+  auto it = llvm::find(scalableDimsToUnroll, true);
   auto firstScalableDim = it - scalableDimsToUnroll.begin();
   if (firstScalableDim == 0)
     return {};
diff --git a/mlir/test/lib/Dialect/Linalg/TestLinalgFusionTransforms.cpp b/mlir/test/lib/Dialect/Linalg/TestLinalgFusionTransforms.cpp
index 81e7eedabd5d1..aab7f30127d96 100644
--- a/mlir/test/lib/Dialect/Linalg/TestLinalgFusionTransforms.cpp
+++ b/mlir/test/lib/Dialect/Linalg/TestLinalgFusionTransforms.cpp
@@ -47,8 +47,7 @@ static LogicalResult fuseLinalgOpsGreedily(func::FuncOp f) {
         if (failed(info))
           continue;
         auto *originalOp = info->originalProducer.getOperation();
-        auto *originalOpInLinalgOpsVector =
-            std::find(linalgOps.begin(), linalgOps.end(), originalOp);
+        auto *originalOpInLinalgOpsVector = llvm::find(linalgOps, originalOp);
         *originalOpInLinalgOpsVector = info->fusedProducer;
         // Don't mark for erasure in the tensor case, let DCE handle this.
         changed = true;

@kazutakahirata kazutakahirata merged commit 2798369 into llvm:main May 13, 2025
17 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_range_llvm_find_mlir branch May 13, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants