Skip to content

[libc] Add struct entry definition in addition to ENTRY according to POSIX. #139773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

lntue
Copy link
Contributor

@lntue lntue commented May 13, 2025

No description provided.

@lntue lntue requested a review from SchrodingerZhu May 13, 2025 18:18
@llvmbot llvmbot added the libc label May 13, 2025
@llvmbot
Copy link
Member

llvmbot commented May 13, 2025

@llvm/pr-subscribers-libc

Author: None (lntue)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/139773.diff

1 Files Affected:

  • (modified) libc/include/llvm-libc-types/ENTRY.h (+1-1)
diff --git a/libc/include/llvm-libc-types/ENTRY.h b/libc/include/llvm-libc-types/ENTRY.h
index ccbd777e2475b..b007c8edba2f5 100644
--- a/libc/include/llvm-libc-types/ENTRY.h
+++ b/libc/include/llvm-libc-types/ENTRY.h
@@ -9,7 +9,7 @@
 #ifndef LLVM_LIBC_TYPES_ENTRY_H
 #define LLVM_LIBC_TYPES_ENTRY_H
 
-typedef struct {
+typedef struct entry {
   char *key;
   void *data;
 } ENTRY;

@lntue lntue requested a review from RossComputerGuy May 13, 2025 18:18
Copy link
Contributor

@enh-google enh-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(oh, yeah, you're right ... i hadn't noticed that this was POSIX. https://pubs.opengroup.org/onlinepubs/9799919799/basedefs/search.h.html confirms you're correct.)

@lntue lntue merged commit 3b62a33 into llvm:main May 13, 2025
16 of 17 checks passed
@lntue lntue deleted the entry branch May 13, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants