-
-
Notifications
You must be signed in to change notification settings - Fork 578
feat(core,schemas): add get user social identities token secret API #7494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
COMPARE TO
|
Name | Diff |
---|---|
packages/core/src/queries/secret.ts | 📈 +933 Bytes |
packages/core/src/routes/admin-user/social.openapi.json | 📈 +931 Bytes |
packages/core/src/routes/admin-user/social.ts | 📈 +1.07 KB |
packages/core/src/routes/connector/index.ts | 📈 +30 Bytes |
packages/schemas/src/types/secrets.ts | 📈 +829 Bytes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new API to retrieve a user's social identity token secret for federated token exchanges and extends the related schema and query functionalities. The key changes include:
- Adding new type guards and types for managing social token set secrets in the schemas package.
- Implementing a new admin route in the core package to expose the secret via a GET request when development features are enabled.
- Enhancing the secret queries with a method to find the social token set secret based on user ID and target.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
packages/schemas/src/types/secrets.ts | Adds new type guards and types to support social token set secrets. |
packages/core/src/routes/admin-user/social.ts | Introduces a new development-only route to retrieve desensitized social token set secrets. |
packages/core/src/queries/secret.ts | Adds a query method to fetch the social token set secret and updates identifier conversion. |
16f748e
to
7cd9392
Compare
9946089
to
22a8847
Compare
add get users social identities token secret API
add api docs
fix patch connector API enableTokenStorage not updated bug
93ce80a
to
91f7970
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, is it doable to add integration tests for the API?
Summary
Add get user's social identity token secret API.
This PR also includes the following updates:
PATCH /api/connectors/:id
endpointenableTokenStorage
not updated bugTesting
test locally
Checklist
.changeset