Skip to content

refactor(core): refactor sso getUserInfo endpoint #7516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

simeng-li
Copy link
Contributor

@simeng-li simeng-li commented Jul 4, 2025

Summary

This PR refactors the return type of the SSO connector’s getUserInfo method.

Previously, the getUserInfo method returned only a userInfo object. However, as we prepare to support token storage for OIDC SSO connectors, we need to return both the fetched user information and the token response to the upper scope. Therefore, the method's return type has been updated as follows:

  • OIDC connectors: { userInfo, tokenResponse }
  • SAML connectors: { userInfo }

Testing

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

@simeng-li simeng-li requested review from a team July 4, 2025 09:50
Copy link

github-actions bot commented Jul 4, 2025

COMPARE TO master

Total Size Diff 📈 +389 Bytes

Diff by File
Name Diff
packages/core/src/routes/interaction/utils/single-sign-on.test.ts 📈 +28 Bytes
packages/core/src/routes/interaction/utils/single-sign-on.ts 📈 +4 Bytes
packages/core/src/sso/AzureOidcSsoConnector/index.ts 📈 +180 Bytes
packages/core/src/sso/OidcConnector/index.ts 📈 +218 Bytes
packages/core/src/sso/OidcConnector/utils.test.ts 📈 +15 Bytes
packages/core/src/sso/OidcConnector/utils.ts 📈 +30 Bytes
packages/core/src/sso/SamlSsoConnector/index.ts 📈 +4 Bytes

@github-actions github-actions bot added enhancement Make it better size/s labels Jul 4, 2025
@github-actions github-actions bot added size/s and removed size/s labels Jul 4, 2025
Base automatically changed from simeng-log-11732-schemascore-add-token-storage-setting-to-sso-connector to master July 7, 2025 08:31
@github-actions github-actions bot added size/s and removed size/s labels Jul 7, 2025
simeng-li added 2 commits July 7, 2025 16:31
Refactor sso getUserInfo endpoint response type.
@simeng-li simeng-li force-pushed the simeng-log-11722-experience-api-refactor-sso-connector-get-user-info branch from 32c7d9c to b6a2dab Compare July 7, 2025 08:31
@github-actions github-actions bot added size/s and removed size/s labels Jul 7, 2025
@simeng-li simeng-li merged commit 6bb1932 into master Jul 8, 2025
61 of 64 checks passed
@simeng-li simeng-li deleted the simeng-log-11722-experience-api-refactor-sso-connector-get-user-info branch July 8, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Make it better size/s
Development

Successfully merging this pull request may close these issues.

2 participants