Skip to content

Communication: Select an Emoji from a suggestion box while typing #10976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from
+411 −8
Open

Communication: Select an Emoji from a suggestion box while typing #10976

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
7c508e3
First version of working suggestion box
LiamFAV Jun 3, 2025
f7282c0
@for add track
LiamFAV Jun 3, 2025
e80dbbb
Fix track $index error
LiamFAV Jun 3, 2025
74d39c4
Test
LiamFAV Jun 3, 2025
1f93dd3
Add suggestion keyboard support
LiamFAV Jun 3, 2025
964082c
Remove ngif
LiamFAV Jun 3, 2025
c97eafc
Add resize listener
LiamFAV Jun 3, 2025
25a5588
Getting emoji list now from emojimart
LiamFAV Jun 3, 2025
ec2b6df
Merge branch 'develop' into feature/emoji-shortcut
Predixx Jun 3, 2025
d35c1a7
Add coderabbitai suggestions for ARIA and magic numbers
LiamFAV Jun 4, 2025
872c8e2
Fix aria selected
LiamFAV Jun 4, 2025
b5be45d
Refactor PostingMarkdownEditor to replace private MonacoEditor API us…
LiamFAV Jun 4, 2025
9d520fe
Move inline styles from HTML to SCSS for better maintainability
LiamFAV Jun 4, 2025
2fda237
Reduce rem values for compact design adjustments in emoji-suggestion-…
LiamFAV Jun 4, 2025
935af44
Merge remote-tracking branch 'origin/feature/emoji-shortcut' into fea…
LiamFAV Jun 4, 2025
fb883c9
Move inline height styling from HTML to posting-markdown-editor.compo…
LiamFAV Jun 4, 2025
8827051
Merge branch 'develop' into feature/emoji-shortcut
LiamFAV Jun 18, 2025
60178d9
Refactor emoji shortcut functionality in markdown editor component us…
LiamFAV Jun 20, 2025
899a158
Fix: Prevent cursor movement with arrow keys when emoji dropdown is open
LiamFAV Jun 20, 2025
f11c032
Fix: Improve keyboard navigation in emoji dropdown and prevent flicke…
LiamFAV Jun 20, 2025
61bd43b
Refactor emoji dropdown positioning to use CSS classes and remove uns…
LiamFAV Jun 20, 2025
c1a55ab
Extract emoji shortcode regex to constant and remove unsafe type asse…
LiamFAV Jun 20, 2025
792de3d
Replace @ViewChild decorator with viewChild signal for emoji dropdown…
LiamFAV Jun 20, 2025
2356fad
Merge branch 'develop' into feature/emoji-shortcut
Predixx Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move inline styles from HTML to SCSS for better maintainability
  • Loading branch information
@LiamFAV
LiamFAV committed Jun 4, 2025
commit 9d520fe6d5aa7b1755ee4dd19b781e75a04e18b7
5 changes: 2 additions & 3 deletions src/main/webapp/app/communication/emoji/emoji-suggestion-dropdown.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,10 @@
(mouseenter)="activeIndex = i"
(mouseleave)="activeIndex = -1"
[attr.aria-selected]="i === activeIndex"
style="display: flex; align-items: center; padding: 1px 0; cursor: pointer"
role="option"
>
<span style="font-size: 1.1em; width: 1.7em">{{ s.emoji }}</span>
<span style="margin-left: 0.4em; font-size: 0.93em">:{{ s.name }}:</span>
<span class="emoji-icon">{{ s.emoji }}</span>
<span class="emoji-name">:{{ s.name }}:</span>
</div>
}
}
Expand Down
14 changes: 14 additions & 0 deletions src/main/webapp/app/communication/emoji/emoji-suggestion-dropdown.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,19 @@
}

.emoji-suggestion-item {
display: flex;
align-items: center;
padding: 1px 0;
cursor: pointer;
border-radius: 4px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no px please

}

.emoji-icon {
font-size: 1.1em;
width: 1.7em;
}

.emoji-name {
margin-left: 0.4em;
font-size: 0.93em;
}