-
-
Notifications
You must be signed in to change notification settings - Fork 439
🌐 New Crowdin updates #1765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 New Crowdin updates #1765
Conversation
[ci skip]
[ci skip]
[ci skip]
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
WalkthroughThis update expands Danish localization support by adding new translation keys and values across landing, web app, and email JSON files. The additions cover licensing, admin setup, user management, authentication errors, community engagement, and related email templates. No existing keys were removed; changes are strictly additive to localization resources. Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
🧹 Nitpick comments (5)
apps/web/public/locales/da/app.json (5)
310-310
: Consider ICU pluralization for paginationThe
paginationPage
string ("Side {currentPage, number} af {totalPages, number}"
) is fine, but if you need to display "Side 1 af 1" vs "Sider", confirm that this meets UI requirements. Otherwise, consider using plural ICU formatting for "Side/Sider" whentotalPages
varies.
346-350
: Unify admin terminology and capitalizationThe admin setup entries use a mix of "Admin Opsætning", "administratoren" and "admin bruger". For clarity, standardize on a single term (e.g., "Administrator") and consistent capitalization (e.g., "administratoropsætning").
351-360
: Inconsistent email casing and terminology
"licenseeEmail": "Licenshavers E-Mail"
uses uppercase "E-Mail", whereas elsewhere "e-mail" is lowercase. Please standardize the casing and ensure the terminology matches other email references.
376-376
: Imperative form and link label in license warningIn
"licenseLimitWarning": "Du har overskredet grænserne for din licens. <a>opgradere</a>."
, the link text "opgradere" is an infinitive. For an action button/link, use the imperative "Opgrader" and capitalize consistently.
394-397
: Lowercase conjunction for natural Danish
"authenticationAndSecurity": "Godkendelse Og Sikkerhed"
capitalizes "Og". In Danish, conjunctions are typically lowercase: "Godkendelse og sikkerhed". Please update for idiomatic grammar.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/landing/public/locales/da/common.json
(1 hunks)apps/web/public/locales/da/app.json
(2 hunks)packages/emails/locales/da/emails.json
(1 hunks)
[ci skip]
[ci skip]
Summary by CodeRabbit
New Features
Style