Skip to content

🌐 New Crowdin updates #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 11, 2025
Merged

🌐 New Crowdin updates #1765

merged 5 commits into from
Jun 11, 2025

Conversation

lukevella
Copy link
Owner

@lukevella lukevella commented Jun 9, 2025

Summary by CodeRabbit

  • New Features

    • Added Danish translations for licensing, admin setup, user management, authentication errors, and security-related messages in the web app and landing page.
    • Introduced new Danish email templates for license key notifications, including purchase confirmation, license details, activation steps, and support information.
  • Style

    • Minor formatting updates to existing translation files to accommodate new entries.

Copy link

vercel bot commented Jun 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
app ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2025 1:56pm
landing ⬜️ Skipped (Inspect) Jun 10, 2025 1:56pm

@vercel vercel bot temporarily deployed to Preview – landing June 9, 2025 16:08 Inactive
Copy link
Contributor

coderabbitai bot commented Jun 9, 2025

Walkthrough

This update expands Danish localization support by adding new translation keys and values across landing, web app, and email JSON files. The additions cover licensing, admin setup, user management, authentication errors, community engagement, and related email templates. No existing keys were removed; changes are strictly additive to localization resources.

Changes

File(s) Change Summary
apps/landing/public/locales/da/common.json Added Danish translations for licensing, community engagement, support prompts, and open-source promotion.
apps/web/public/locales/da/app.json Added Danish translations for pagination, admin setup, licensing, user management, authentication errors, and security settings.
packages/emails/locales/da/emails.json Added Danish email template translations for license key notifications and related instructions.

Possibly related PRs

  • lukevella/rallly#1751: Adds new localization keys for licensing, onboarding, and support messages in other locale files.
  • lukevella/rallly#1761: Introduces similar localization updates for Dutch, focusing on licensing, user management, and admin features.

Poem

A rabbit hopped through Danish fields,
With keys and strings its language yields.
Licenses, users, emails anew—
Translations bright, the list just grew!
From admin panels to support’s embrace,
Danish speakers now find their place.
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1c1fdd7 and fe4d65c.

📒 Files selected for processing (2)
  • apps/web/public/locales/da/app.json (2 hunks)
  • packages/emails/locales/da/emails.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/emails/locales/da/emails.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/web/public/locales/da/app.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (5)
apps/web/public/locales/da/app.json (5)

310-310: Consider ICU pluralization for pagination

The paginationPage string ("Side {currentPage, number} af {totalPages, number}") is fine, but if you need to display "Side 1 af 1" vs "Sider", confirm that this meets UI requirements. Otherwise, consider using plural ICU formatting for "Side/Sider" when totalPages varies.


346-350: Unify admin terminology and capitalization

The admin setup entries use a mix of "Admin Opsætning", "administratoren" and "admin bruger". For clarity, standardize on a single term (e.g., "Administrator") and consistent capitalization (e.g., "administratoropsætning").


351-360: Inconsistent email casing and terminology

"licenseeEmail": "Licenshavers E-Mail" uses uppercase "E-Mail", whereas elsewhere "e-mail" is lowercase. Please standardize the casing and ensure the terminology matches other email references.


376-376: Imperative form and link label in license warning

In "licenseLimitWarning": "Du har overskredet grænserne for din licens. <a>opgradere</a>.", the link text "opgradere" is an infinitive. For an action button/link, use the imperative "Opgrader" and capitalize consistently.


394-397: Lowercase conjunction for natural Danish

"authenticationAndSecurity": "Godkendelse Og Sikkerhed" capitalizes "Og". In Danish, conjunctions are typically lowercase: "Godkendelse og sikkerhed". Please update for idiomatic grammar.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7d25950 and 1c1fdd7.

📒 Files selected for processing (3)
  • apps/landing/public/locales/da/common.json (1 hunks)
  • apps/web/public/locales/da/app.json (2 hunks)
  • packages/emails/locales/da/emails.json (1 hunks)

@vercel vercel bot temporarily deployed to Preview – landing June 10, 2025 13:55 Inactive
@lukevella lukevella merged commit 57d8ca5 into main Jun 11, 2025
5 checks passed
@lukevella lukevella deleted the l10n_main branch June 11, 2025 09:42
@coderabbitai coderabbitai bot mentioned this pull request Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant