Skip to content

fix(Dock Demo 3): 🐛 fix issue with Dock Demo 3 #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Raxuis
Copy link

@Raxuis Raxuis commented Sep 6, 2024

Hello,
When using the Dock Demo 3 I found that on responsive it had extra padding on y axis so I fixed the issue by replacing p by px.
Hoping it suits you!
Raphaël

fix issue with Dock Demo 3 having extra padding on y axis
Copy link

vercel bot commented Sep 6, 2024

@Raxuis is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

@alamenai
Copy link
Contributor

alamenai commented Sep 7, 2024

@Raxuis , please could share a demo of the issue ( screenshot or screencast) to reproduce the issue and on which devices it happened?

@Raxuis
Copy link
Author

Raxuis commented Sep 7, 2024

IMG_4346
Here is the screenshot on my mobile phone. It's an iPhone 15 Pro Max.

@alamenai
Copy link
Contributor

alamenai commented Sep 7, 2024

Thank you @Raxuis , Yes I found that same issue. When we put px-3 will not this impact the behavior in the Desktop? because the py became 0, right?

@Raxuis
Copy link
Author

Raxuis commented Sep 7, 2024

Capture d’écran 2024-09-07 à 22 09 09

I don't know. I thought that it still looked fine.

@Raxuis
Copy link
Author

Raxuis commented Sep 10, 2024

Do you think it could be a good idea to merge it?

@itsarghyadas
Copy link
Collaborator

closing this in favour of #454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants