🐛 fix(vditor): avoid clearing classes set by vditor when setting class #2398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #2392 by ensuring classes set by Vditor are preserved when applying custom classes to the markdown component. The key changes include:
- Introducing a new BuildComponentClass method that always returns "vditor" as a default class.
- Conditionally adding "vditor-dark" based on the provided Options' theme.
- Preventing accidental override of the default vditor class.
Qinyouzeng
approved these changes
May 8, 2025
capdiem
added a commit
that referenced
this pull request
May 8, 2025
#2398) * 🐛 fix(vditor): avoid clearing classes set by vditor when setting class * update comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2392