refactor(ScrollToTarget): implement debounced update for active target handling #2404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ScrollToTarget component to implement a debounced update for active target handling.
- Updates the manifest to reference the new scroll-to-target JS file
- Implements debounced updates in both JavaScript and C# components
- Removes the deprecated duplicate 'lastTarget' field in the C# component
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Masa.Blazor/wwwroot/js/manifest.json | Updated file hash reference for scroll-to-target JS file |
| src/Masa.Blazor/wwwroot/js/components/scroll-to-target/index-d22e7344.js | Introduces debounced update wrapping for invoking UpdateActiveTarget |
| src/Masa.Blazor/wwwroot/js/components/scroll-to-target/index-0c459122.js | Removed outdated implementation |
| src/Masa.Blazor/Components/ScrollToTarget/MScrollToTarget.cs | Removes unused field and adds guard on updating active target |
| src/Masa.Blazor.JS/src/components/scroll-to-target/index.ts | Replaces direct call with a debounced update using a debounce utility |
| internal async ValueTask UpdateActiveTarget(string target) | ||
| { | ||
| if (_targetContext.ActiveTarget == target) |
There was a problem hiding this comment.
[nitpick] The method now compares _targetContext.ActiveTarget with the parameter value before updating a separate lastTarget field. To improve maintainability, consider using a single source of truth for the active target state—either consistently update _targetContext or replace its use with lastTarget.
Copilot uses AI. Check for mistakes.
MayueCif
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.