Skip to content

🆕 feat: add VideoFeed component #2433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025
Merged

🆕 feat: add VideoFeed component #2433

merged 3 commits into from
May 30, 2025

Conversation

capdiem
Copy link
Contributor

@capdiem capdiem commented May 30, 2025

No description provided.

@capdiem capdiem marked this pull request as ready for review May 30, 2025 03:53
@capdiem capdiem requested a review from Copilot May 30, 2025 03:53
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new VideoFeed component feature with styling, JavaScript/TypeScript helpers, and Blazor components to support interactive video playback and fullscreen controls. In addition, the documentation for mobile swiper usage has been updated to include video feed alerts.

  • Added VideoFeed CSS styles.
  • Implemented JavaScript/TypeScript modules for video feed behavior.
  • Introduced new Blazor components (MVideoFeed, MRichVideo, and MVideoControls) and updated mobile documentation.

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/Masa.Blazor/wwwroot/css/masa-blazor.extend.css Added CSS styles for the video feed UI.
src/Masa.Blazor.JSComponents.Swiper/wwwroot/video-feed.js Added a JS helper for video feed management.
src/Masa.Blazor.JSComponents.Swiper/VideoFeed/*.cs and .razor files Introduced Blazor components for video feed functionality.
src/Masa.Blazor.JS/src/proxies/swiper/video-feed.ts Added TypeScript module to support video feed operations.
docs/Masa.Blazor.Docs/wwwroot/pages/mobiles/swiper/*.md Updated mobile swiper documentation with video feed alerts.
Comments suppressed due to low confidence (2)

src/Masa.Blazor.JSComponents.Swiper/wwwroot/video-feed.js:1

  • Consider renaming class 'e' to 'VideoFeed' (or another descriptive name) to improve readability and maintainability.
class e{constructor(e,t){this.videoSelector=e,this.dotNetHelper=t,this.videoEl=document.querySelector(e)}init(){...}

src/Masa.Blazor.JSComponents.Swiper/VideoFeed/MVideoFeed.razor.cs:7

  • Initializing a List using an empty array literal ([]) is non-standard; consider using 'new List
[Parameter] public List<Video> Videos { get; set; } = [];

@MayueCif MayueCif merged commit 152361a into main May 30, 2025
1 check passed
@MayueCif MayueCif deleted the feature/video-feed branch May 30, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants