-
Notifications
You must be signed in to change notification settings - Fork 3
Remove redundant [<RequireQualifiedAccess>] #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
@cotyar looks like you deleted the |
Ops ... apologise
Shall we get the latest bootstrapper and rename it into paket.exe?
…On Sat, 17 Mar 2018, 21:05 Tomas Jansson, ***@***.***> wrote:
@cotyar <https://github.com/cotyar> looks like you deleted the
paket.bootstrapper.exe file. I use that in the build script to get the
latest paket.exe.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEvtbek0JRaKF_rdeDslyHsKWviK6Wwxks5tfXqAgaJpZM4SuEFu>
.
|
@cotyar why do you think we should do that? Can't we just have it named |
To be clear, I'm not saying I'm right or wrong here. Recommendation here states that it is the bootstrapper that should be added to source control: https://fsprojects.github.io/Paket/faq.html#What-files-should-I-commit |
Happy with any of the options - it is totally your call.
It can be done because of: When paket.bootstrapper.exe is renamed to
paket.exe, the real paket.exe is downloaded to a temporary location and
executed with all arguments passed directly.
fsprojects.github.io/Paket/bootstrapper.html
…On Sat, 17 Mar 2018, 21:44 Tomas Jansson, ***@***.***> wrote:
To be clear, I'm not saying I'm right or wrong here. Recommendation here
states that it is the bootstrapper that should be added to source control:
https://fsprojects.github.io/Paket/faq.html#What-files-should-I-commit
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEvtbapitSUA9_SzNrzdvcvI2No5mH3aks5tfYPagaJpZM4SuEFu>
.
|
let's go for your suggestion then :) |
Changed benchmark to use TotalSeconds
Inlined everything
Concept of Effects added Some optimizations done
No description provided.