Fix issue where python's sys.module dict fails to convert to a MATLAB dictionary #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #68
The following line in
Zarr/pySetup
attempts to convert thesys.modules
python dict to a MATLAB dictionary.MATLAB-support-for-Zarr-files/Zarr.m
Line 52 in 0c96a28
When running this, I get the following error:
I have not explored why, but I assume I have a python module installed which fails to convert to a MATLAB type.
Here I propose to only convert the keys of the dict to a string array and check if ZarrPy is part if that array. I also added try catch to ensure there is a fallback if the check fails.