-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Seeed Studio XIAO nrf52-based boards modularization #6788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
7f855f3
to
1814dff
Compare
Thanks for putting so much thought into this |
Based on suggestions on Discord#nrf52, moved the DIY (board_level = extra) boards into DIY and inherited the environments from the non-DIY XIAO. It may be a bit more confusing since all the pin logic is in the variant.h of another folder, but I added a comment to variants/diy/platformio.ini that directs devs to that variant.h. Either approach of (a) having all the extra build envs in the official variant or (b) having all the extra build envs in DIY is fine by me, up to the maintainers to decide which is preferable. |
Hm, an unintended consequence of deriving everything from the officially supported board is that they will show up with the supported hardware model over the mesh instead of unsupported hardware. Is that okay? If not, I will add -DPRIVATE_HW to the DIY environments. |
|
I shall add a variant in to cover the old PCB use case, but what's a good name for the env section? |
That is a very good question! Perhaps something that explicates it's DIY or the PCB rev ala |
Good idea. I won't touch the original env name for the nrf kit, but the
Oh yes, I noticed the Is that actually valid? |
|
@porkcube please test this commit -> I believe it should be feature/pinout parity with the removed variant. |
Summary updated to reflect the changes since. |
@ndoo Confirming Thank you so much for cleaning up the variant mess and for the Ikokas! |
That’s a relief. As long as there’s no regression I hope these variants are
useful to the community.
If this gets merged I actually have a local branch which adds a bunch of
E22 variants …
…On Mon, May 12, 2025 at 02:23 porkcube ***@***.***> wrote:
*porkcube* left a comment (meshtastic/firmware#6788)
<#6788 (comment)>
@ndoo <https://github.com/ndoo> Confirming
seeed_xiao_nrf52840_wio-sx1262_v1_1 works as expected (node boots up
fine, and user button detected).
Thank you so much for cleaning up the variant mess and for the Ikokas!
—
Reply to this email directly, view it on GitHub
<#6788 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACAFACMTTZKM5BD5NY4OKL256ITZAVCNFSM6AAAAAB43UT4Y6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNZQGAZTQOBRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
The diy variants need to be properly labeled as diy |
Rebased on |
Squashed commits for readability |
be708b2
to
6b964a7
Compare
6b964a7
to
28ff399
Compare
71ea37f
to
96d0036
Compare
…variants/diy Signed-off-by: Andrew Yong <[email protected]>
…2 PCB v1.1 Signed-off-by: Andrew Yong <[email protected]>
Signed-off-by: Andrew Yong <[email protected]>
- Remove as it's superseded by seeed_xiao_nrf52840_wio-sx1262_v1_1 Signed-off-by: Andrew Yong <[email protected]>
diy/seeed-xiao-nrf52840-wio-sx1262
variant🤝 Attestations