Switch to upstream specta #51
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukipuki
reviewed
Jun 17, 2025
| "export", | ||
| "chrono", | ||
| ] } | ||
| specta-typescript = { git = "https://github.com/specta-rs/specta.git", rev = "2391e55", optional = true } |
There was a problem hiding this comment.
Can you add a comment why we depend on both commits 2391e55 and export them as two separate modules/crates?
There was a problem hiding this comment.
that's two different crates an a single repo
There was a problem hiding this comment.
I see now, it's two different crates in two different directories.
lukipuki
approved these changes
Jun 21, 2025
|
This is marked as draft, I assume you don't want to merge yet? |
|
Yeah, let it hang for a while as a draft - I'm not a user of JS part of the project, may be someone would like to test it until specta will stabilize a bit more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since specta-rs/specta#62 is resolved now we could switch to the upstream.
Marking it as a draft since proper release of specta crate is yet to come.