Skip to content

Fixes and improvements to meshtastic.rs generation #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2025

Conversation

krant
Copy link
Contributor

@krant krant commented Jun 27, 2025

Copy link
Contributor

@brannondorsey brannondorsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @krant. I can confirm that this fixes the issue, and successive builds with --features ts-config, --features serde, and the default features all succeed and leave the project compilable afterwords without issue.

I left one small nonblocking comment.

build.rs Outdated
Comment on lines 54 to 55
#[cfg(feature = "serde")]
{
Copy link
Contributor

@brannondorsey brannondorsey Jun 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we want to take a similar approach for the #[serde(rename_all = \"camelCase\")] attribute just below here as well?

Also, I think the two #[allow(clippy::*)] attributes may be something that can be added independent of whether the serde feature is enabled or not. That's at least what my understanding was here in this PR last week: #52 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice improvement, thanks @brannondorsey. build.rs looks way better now.

@krant krant changed the title Fix idempotent builds Fixes and improvements to meshtastic.rs generation Jun 29, 2025
@lukipuki
Copy link
Collaborator

Please fix the conflict and then I can merge

@krant
Copy link
Contributor Author

krant commented Jun 30, 2025

@lukipuki rebased on top of main

@lukipuki lukipuki merged commit 6575866 into meshtastic:main Jun 30, 2025
3 checks passed
@krant krant deleted the fix_gen branch June 30, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building with --features ts-gen corrupts future builds without it
3 participants