Skip to content

Fix clippy warnings #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged

Fix clippy warnings #55

merged 1 commit into from
Jul 1, 2025

Conversation

krant
Copy link
Contributor

@krant krant commented Jun 30, 2025

Make cargo clippy happy

Copy link
Collaborator

@lukipuki lukipuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and the last CI run of cargo clippy was successful, did you encounter any errors?

@@ -36,7 +36,7 @@ where
Ok(())
}
e = handle => {
error!("Read handler unexpectedly terminated: {:#?}", e);
error!("Read handler unexpectedly terminated: {e:#?}");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely on-board with this clippy rule but let's accept it 🙂

@krant
Copy link
Contributor Author

krant commented Jul 1, 2025

My guess is that recent Rust update has introduced them - my local cargo clippy was erroring. I have no opinion regarding CI should catch those when Rust updates - pinned compiler version is good for reproducibility, so both approaches have their advantages.

@lukipuki
Copy link
Collaborator

lukipuki commented Jul 1, 2025

I figured it out, it's a new rule in 1.88 that came out last week. Trying with cargo +1.87.0 clippy doesn't produce any warning.

@lukipuki lukipuki merged commit dfc6100 into meshtastic:main Jul 1, 2025
3 checks passed
@lukipuki
Copy link
Collaborator

lukipuki commented Jul 1, 2025

If we want to make developers' lives easier, we can provide a rust-toolchain.toml file which would pin the local Rust version and it would prevent similar situations in the future.

@krant
Copy link
Contributor Author

krant commented Jul 1, 2025

pin the local Rust version

I'd avoid introducing rust-toolchain.toml if the only driver for that is clippy. I hope this directive will help us to mitigate future version-related clippy hiccups.

@krant krant deleted the clippy branch July 1, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants