Better code style in build.rs

[krant]

• No more unwraps in build.rs
• More idiomatic directory traversal (without for)
• Fix warnings from cargo clippy --features ts-gen on Rust 1.88

[lukipuki]

Note that the build is currently broken because of bluez-async: https://discord.com/channels/867578229534359593/1148012739575418932/1389540482761101402
We need to fix it ASAP.

[krant]

My guess we should change cargo +1.76.0 here to cargo +1.85.0.

[lukipuki]

My guess we should change cargo +1.76.0 here to cargo +1.85.0.

This is not the right way to do it, we set rust-version = "1.76" in Cargo.toml, we should use the same version in CI to verify the crate builds with 1.76.

[krant]

But it looks bluetooth crates ecosystem moved on to Rust 2024. Shouldn't we set rust-version = "1.85" then?

[lukipuki]

I don't think we should (it could break someone's build) if there's better solutions: #57

[krant]

Looks good! Let's merge #57 so I could rebase my PR on top.

[lukipuki]

Looks good! Let's merge #57 so I could rebase my PR on top.

Done

[lukipuki]

Suggested change

	.map(|x| x.path().to_owned())
	.filter(|x| x.extension() == Some(std::ffi::OsStr::new("proto")))
	.map(|x| x.into_path())
	.filter(|x| x.extension().is_some_and(|ext| ext == "proto"))

[krant]

Awesome, done

[lukipuki]

out_dir is not a good name, it already has a meaning inside of build.rs:
https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-crates

I'd keep the original gen_dir.

[krant]

makes sense, done