Skip to content

Add Python 3.9 ARM64 wheel #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2025
Merged

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Apr 28, 2025

No description provided.

@Avasam Avasam force-pushed the Add-Python-3.9-ARM64-wheels branch from d4b3958 to 3286139 Compare April 28, 2025 00:06
@Avasam Avasam changed the title Add Python 3.9 ARM64 wheels Add Python 3.9 ARM64 wheel Apr 28, 2025
Copy link
Owner

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think a changelog is necessary here.

@Avasam Avasam requested a review from mhammond April 28, 2025 14:53
@Avasam
Copy link
Collaborator Author

Avasam commented Apr 28, 2025

Whilst not a code change I wondered if we wanted to communicate it or just let people figure out we now support all non-EOL Python on ARM64

@Avasam
Copy link
Collaborator Author

Avasam commented Apr 28, 2025

First time I see a test fail due to a fie lock:
https://github.com/mhammond/pywin32/actions/runs/14710866513/job/41282638925?pr=2584#step:10:426

======================================================================
ERROR: test_exe (test_exe.TestPythonwinExe)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\pywin32\pywin32\Pythonwin\pywin\test\test_exe.py", line 70, in tearDown
    os.remove(self.tfn)
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\pywintest-32v28jot.testout.txt'

======================================================================
FAIL: test_exe (test_exe.TestPythonwinExe)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\pywin32\pywin32\Pythonwin\pywin\test\test_exe.py", line 65, in test_exe
    self.assertEqual(rc, 0, f"outs={outs!r}")
AssertionError: 'TIMEOUT' != 0 : outs=''

Completely unrelated to my change, given there's no code change, that failed in 3.10 when I added 3.9.10, and it failed in a completely different job.
So that's a (new?) flaky test...

CHANGES.txt Outdated
@@ -1,4 +1,4 @@
Notable changes in recent builds.
Notable changes in recent builds.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this phantom change?

Copy link
Collaborator Author

@Avasam Avasam Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think CHANGES.txt has a weird hidden first character (it shows up as a red dot in GitHub's file editor, I've been noticing it for a while).
image

I think it's a Byte Order Mark. VSCode opens this file as UTF-8 with BOM by default.

I guess when I discarded this file from GitHub it must've changed that. I'll try again using the CLI.

Copy link
Owner

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Avasam Avasam merged commit d764900 into mhammond:main Apr 28, 2025
31 checks passed
@Avasam Avasam deleted the Add-Python-3.9-ARM64-wheels branch April 28, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants