Add missing board images #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the PICOLIPO also appears to have a missing image:
...but the I noticed that there was an update to the board image a couple of days ago - so I'm hoping that the problem is that the image just hasn't yet been copied across to the build machine? |
Signed-off-by: Matt Trentini <[email protected]>
Signed-off-by: Matt Trentini <[email protected]>
Signed-off-by: Matt Trentini <[email protected]>
Signed-off-by: Matt Trentini <[email protected]>
Signed-off-by: Matt Trentini <[email protected]>
Signed-off-by: Matt Trentini <[email protected]>
Signed-off-by: Matt Trentini <[email protected]>
Signed-off-by: Matt Trentini <[email protected]>
Signed-off-by: Matt Trentini <[email protected]>
Signed-off-by: Matt Trentini <[email protected]>
Signed-off-by: Matt Trentini <[email protected]>
Signed-off-by: Matt Trentini <[email protected]>
Signed-off-by: Matt Trentini <[email protected]>
dpgeorge
force-pushed
the
add-missing-images
branch
from
b46277f to
2afb937
Compare
|
Thank you very much! |
|
The Pico Lipo board looks like it has updated now on the downloads page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update board images
There are some missing images at MicroPython Downloads; this PR attempts to resolve all the current issues.
Also see micropython/micropython#15677 that includes modifications to the various
board.jsonfiles.No images
The
board.jsonfiles for these boards had no image entry. Addedboard.jsonentries and images.Image not found
These
board.jsonfiles had entries but no image. Just added the image (and, in some cases, updated empty URLs in theboard.jsonfile).Image too large
Just resized the images to keep them below the nominal 500KB limit.