Skip to content

Fixed control flow Analysis of aliased discriminants with parenthesized initializers #61788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Andarist
Copy link
Contributor

fixes #61784

@Copilot Copilot AI review requested due to automatic review settings May 31, 2025 13:57
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog May 31, 2025
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 31, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where discriminant properties aliased through parenthesized or destructured initializers weren't correctly recognized in control-flow analysis.

  • Added comprehensive tests covering both direct and parenthesized/destructured alias patterns.
  • Refactored the alias resolution logic in the type checker to use a helper that skips parentheses.
  • Introduced getCandidateVariableDeclarationInitializer to centralize initializer extraction.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
tests/cases/conformance/controlFlow/controlFlowAliasing2.ts New tests for aliased discriminants with various initializer forms
tests/baselines/reference/controlFlowAliasing2.symbols Baseline update for the new conformance tests
src/compiler/checker.ts Extracted initializer logic into a helper and updated alias-matching branches
Comments suppressed due to low confidence (1)

src/compiler/checker.ts:29266

  • [nitpick] Consider renaming this helper to something shorter like getInitializerSkippingParens or extractInitializer for improved readability.
function getCandidateVariableDeclarationInitializer(node: Node) {

@Harpush
Copy link

Harpush commented Jul 1, 2025

Any chance for this passing?

@jakebailey
Copy link
Member

@typescript-bot test it

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 1, 2025

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started ✅ Results
user test this ✅ Started
run dt ✅ Started ✅ Results
perf test this faster ✅ Started

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61788/merge:

Everything looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Status: Not started
Development

Successfully merging this pull request may close these issues.

Parenthesis break narrowing.
4 participants