code review changes: getStream, file structure, generate definitions #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -67,27 +67,26 @@ export class HttpClient implements ifm.IHttpClient { | |||
| content.pipe(req); | |||
| } | |||
|
|
|||
| getFile(requestUrl: string, destination: NodeJS.WritableStream, headers: any, onResult: (err: any, res: http.ClientResponse) => void): void { | |||
| getStream(requestUrl: string, apiVersion: string, type: string, onResult: (err: any, statusCode: number, res: http.ClientResponse) => void): void { | |||
There was a problem hiding this comment.
getStream here: wasn't totally sure if the callback should include the status code here -- it doesn't on other http client methods, but used to on the rest client
also made the changes to Agent.XPlat locally to use this -- should I start putting the changes that I make there on a new branch?
teddyward
pushed a commit
that referenced
this pull request
Jul 13, 2015
code review changes: getStream, file structure, generate definitions
themadtitanmathos
pushed a commit
to themadtitanmathos/azure-devops-node-api
that referenced
this pull request
Apr 9, 2021
…nk-is-browser-check DEV-943: isBrowser === true while in a node application using electron-link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.