removed array wrapping and updated clients #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why the diff here shows the entire file as changing instead of individual lines... that kind of sucks. nvm. CRLF/LF problem. Resubmitting... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods in RestClient.ts that handled JsonWrappedArrays are no longer necessary because the generator will use VSSJsonCollectionWrappers whenever the controllers do. They actually caused problems in the generator logic because sometimes arrays that are taken as body parameters or returned are NOT wrapped up in that {count:number, value:T} form. This caused a 400, for example, on the previous version of the generated TestApi.addTestResultsToTestRun method.
Also updated the clients to the newest version in VSO.
Bumped version to 0.4.0