Mirror typed-rest-client options #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-zaytsev
approved these changes
Aug 7, 2024
DergachevE
approved these changes
Aug 7, 2024
DmitriiBobreshev
deleted the
users/v-bobreshevd/mirror-typed-rest-client-options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The PR mirroring IRequestOptions from typed-rest-client.
This is needed, because VsoBaseInterfaces.IRequestOptions uses with WebApi and ClientApiBases which is, basically, wrappers for typed-rest-client's HttpClient and RestClient.
Also, this is potential fix for the problem with 5sec timeout.
Since node19 http.GlobalAgent has 5 sec timeout which might be too short for Azure REST API.
By adding keppAlive request option we assign to request own agent with null timeout(as it was previously) instead of global one with 5sec timeout.
In case if proxy will be specified, the specific agent will be created as well without timeout option.
Related WI: AB#2194177
Tested: tested locally