Added support for url-encoding the data in case the content-type is application/x-www-form-urlencoded #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pplication/x-www-form-urlencoded
kmkumaran
approved these changes
Nov 18, 2016
ericsciple
reviewed
Nov 18, 2016
| @@ -7,6 +7,7 @@ import http = require("http"); | |||
| import https = require("https"); | |||
| import tunnel = require("tunnel"); | |||
| import ifm = require('./interfaces/common/VsoBaseInterfaces'); | |||
| import querystring = require('querystring'); | |||
There was a problem hiding this comment.
i dont see this module defined in the package.json
ericsciple
reviewed
Nov 20, 2016
| @@ -179,7 +180,14 @@ export class HttpClient implements ifm.IHttpClient { | |||
| var socket; | |||
|
|
|||
| if (objs) { | |||
| reqData = JSON.stringify(objs, null, 2); | |||
| var urlEncFormContentType: boolean = options.headers["Content-Type"] && options.headers["Content-Type"].indexOf("application/x-www-form-urlencoded") != -1; | |||
There was a problem hiding this comment.
rather than inspecting headers, has an alternative been considered where a flag can be passed-in that indicates "don't JSON stringify", and leave it up to the caller to pre-format the data as desired.
There was a problem hiding this comment.
This will be a moot point. It's changing to be a Buffer. It's up to the consumer to json'ify or not. This is an http client and it should not be biased toward JSON. However, the layer above it (rest client) will be.
|
as noted above, moot point in new pattern |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.