Skip to content

update + remove unnecessary param #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

teddyward
Copy link

  • Updated the clients after pulling changes in VSO
  • Removed unnecessary content: string parameter in all upload methods (already had contentStream: NodeJS.ReadableStream)

@teddyward
Copy link
Author

When this gets merged tfs-cli will be broken until microsoft/tfs-cli#6 is merged

@bryanmacfarlane
Copy link
Contributor

OK - so if you're breaking compat, then the right thing to do is increment the minor version. When the tfx complementing PR goes in that needs to up it's consumption semver. That ensures that any installs of tfx in that window will still work. Swing by if the semver stuff isn't clear.

Update this PR with the package ver bump and I'll look

@teddyward
Copy link
Author

OK. I think that we actually need to bump the major version to not break existing tfx installs since we used "vso-node-api": "^0.2.6" in the tfx package.json. As I understand it, the ^ will make it pull the most recent minor version... I guess I should change the '^' to '~' (which only bumps on patches) for the future.
And in the meantime I guess I have to make this 1.0 to save current installs. oops.

@@ -1,7 +1,7 @@
{
"name": "vso-node-api",
"description": "Node client for Visual Studio Online/TFS REST APIs",
"version": "0.2.6",
"version": "0.3.6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should 0.3.0

@teddyward teddyward closed this Aug 7, 2015
@teddyward teddyward deleted the users/teddyward/update branch August 7, 2015 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants