Skip to content

Move vision token file to FluentUI_common module #2161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented May 22, 2025

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Although theoretically we only need the vision token file in the iOS module, we still reference it in the common module in FluentTheme.swift. Moving it to FluentUI_common.

Verification

Demo app builds

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@joannaquu joannaquu requested a review from a team as a code owner May 22, 2025 17:32
Copy link
Contributor

@mischreiber mischreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can take this change to unblock the build for right now, but I'm working on a new way to inject platform-specific tokens. It's intended for macOS, but visionOS will benefit as well.

@joannaquu joannaquu merged commit 20162ed into microsoft:main May 22, 2025
7 checks passed
@joannaquu joannaquu deleted the joannaqu/fix-vision branch May 22, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants