-
Notifications
You must be signed in to change notification settings - Fork 32
Add appinsights telemetry #1684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dagood
reviewed
Jun 2, 2025
mertakman
approved these changes
Jun 3, 2025
f9aa8b2
to
5bc229e
Compare
dagood
approved these changes
Jun 5, 2025
Co-authored-by: Davis Goodin <[email protected]>
dagood
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes all
go
executions upload telemetry data to Azure Application Insights as an opt-in feature which requires manually setting an instrumentation key. Therefore is safe to merge into main until we pass the privacy review.Set this env variable to enable telemetry on your computed:
MS_GOTOOLCHAIN_TELEMETRY_INSTRUMENTATION_KEY
will be removed once we have the final instrumentation key, which will be hardcoded.MS_GOTOOLCHAIN_TELEMETRY_ALLOW_GO_DEVEL
will probably stay, but won't be necessary for users outside our team.I've done some local benchmarking, and the telemetry upload takes ~300ms, which is a reasonable amount of time.
Closes #1672.
Note for reviewers: you don't really need to review most of the new lines. Skip those under
src/cmd/vendor
, as they aregithub.com/microsoft/go-infra/telemetry
being vendored.