-
Notifications
You must be signed in to change notification settings - Fork 9
Ensure instructions to build work on arm and amd #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
w/o using dockerx builds the normal docker-build, docker-push failed to work properly as the setup documentation stated on ARM clusters. This change simply makes the build work more like oadp-operator.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weshayutin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thoughts on just making multi platform images always? This controller image should be small enough that its going to create productivity not having to ask someone to rebuild for their arch for less than a minute of additional build time. |
That is a valid point and one side of the issue. If I recall correctly folks involved in this project perfered to build quickly vs build all arch types ( it was annoying ). We def do not need to build for ppc or s390. IIUC, we are building oadp-operator based on the arch of the cluster. Seems like the right pattern to follow here as well. |
@weshayutin which way will this PR go? multi-arch as @kaovilai suggested or rebase to resolve Makefile conflict? |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The operator takes a long time hence only single arch. Also it would've required a lot of rework of oadp makefile to build mutiarch oadp. This repo is not the case because of lack of operator sdk bundle building |
w/o using dockerx builds the normal docker-build, docker-push failed to work properly as the setup documentation stated on ARM
clusters. This change simply makes the build work more like
oadp-operator.
Why the changes were made
building w/ ARM failed when using
https://github.com/migtools/oadp-non-admin/blob/master/docs/CONTRIBUTING.md
How to test the changes made
Tested w/ both ARM and AMD clusters. :) works