Skip to content

fix versioning by setting current_version in bumpver #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

gumaerc
Copy link
Contributor

@gumaerc gumaerc commented May 5, 2025

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/7257

Description (What does it do?)

This PR fixes versioning of the API client library by setting current_version in the bumpver configuration in pyproject.toml. This is needed for the version to be properly incremented.

How can this be tested?

This change needs to be merged before the pipeline is run again to test it.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @gumaerc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses issue #7257 by fixing the versioning of the API client library. The primary change involves updating the bumpver configuration in pyproject.toml to include current_version and ensure it's correctly incremented. Specifically, the current_version is updated to "2025.4.30", and a new file pattern '^current_version = "{version}"' is added to tool.bumpver.file_patterns to ensure the version is properly updated in pyproject.toml.

Highlights

  • Versioning Fix: The PR fixes the API client library versioning by correctly setting the current_version in the bumpver configuration.
  • pyproject.toml Update: The pyproject.toml file is modified to update the current_version and add a new file pattern for version updating.

Changelog

  • pyproject.toml
    • Updated current_version from "2024.1.1" to "2025.4.30".
    • Added '^current_version = "{version}"' to tool.bumpver.file_patterns to ensure the version is properly updated.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


In TOML we seek,
A version to tweak,
Bumpver's the tool,
To keep it all cool,
And updates unique.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR updates the current_version in pyproject.toml and adds a file pattern for current_version to be updated by bumpver. The changes seem straightforward and address the issue of versioning the API client library.

Merge Readiness

The changes appear to be correct and address the intended issue. Since there are no critical or high severity issues, the pull request is likely ready to be merged after addressing the medium severity issue. I am unable to approve the pull request, and recommend that others review and approve this code before merging.

@gumaerc gumaerc added the Needs Review An open Pull Request that is ready for review label May 5, 2025
Copy link

@rhysyngsun rhysyngsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gumaerc gumaerc merged commit f7a9520 into main May 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review An open Pull Request that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants