Fix: Use self.getConfig to access a specific config value. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix allows this extension to work with python-markdown v2.4, which is what ships with Ubuntu 14 LTS. Without this fix, I see:
C:\blah>python -m markdown -x enki.plugins.preview.mdx_math
Traceback (most recent call last):
File "C:\Python27\lib\runpy.py", line 162, in _run_module_as_main
"__main__", fname, loader, pkg_name)
File "C:\Python27\lib\runpy.py", line 72, in _run_code
exec code in run_globals
File "C:\Python27\lib\site-packages\markdown\__main__.py", line 87, in <module>
run()
File "C:\Python27\lib\site-packages\markdown\__main__.py", line 81, in run
markdown.markdownFromFile(**options)
File "C:\Python27\lib\site-packages\markdown\__init__.py", line 438, in markdownFromFile
md = Markdown(**kwargs)
File "C:\Python27\lib\site-packages\markdown\__init__.py", line 137, in __init__
configs=kwargs.get('extension_configs', {}))
File "C:\Python27\lib\site-packages\markdown\__init__.py", line 165, in registerExtensions
ext.extendMarkdown(self, globals())
File "C:\Users\bjones\Documents\python-markdown-math\mdx_math.py", line 38, in extendMarkdown
File "C:\Python27\lib\site-packages\markdown\extensions\__init__.py", line 28, in getConfigs
return dict([(key, self.getConfig(key)) for key in self.config.keys()])
AttributeError: 'list' object has no attribute 'keys'
bjones1
pushed a commit
to bjones1/enki
that referenced
this pull request
Nov 18, 2015
bjones1
pushed a commit
to bjones1/enki
that referenced
this pull request
Nov 18, 2015
|
Thanks, merged! |
mitya57
added a commit
to retext-project/pymarkups
that referenced
this pull request
Dec 13, 2015
…< 2.6 Fix contributed by Bryan A. Jones in mitya57/python-markdown-math#7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows this extension to work with python-markdown v2.4, which is what ships with Ubuntu 14 LTS. Without this fix, I see: