Skip to content

BUG: Fixes for old sklearn #13308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 5, 2025
Merged

BUG: Fixes for old sklearn #13308

merged 9 commits into from
Jul 5, 2025

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Jul 3, 2025

Closes #13138

Should expose the problem first (true TDD!). Then I'll push fixes, then uncomment the other CI runs.

@larsoner larsoner added this to the 1.10 milestone Jul 3, 2025
@drammock
Copy link
Member

drammock commented Jul 3, 2025

problem exposed!

FAILED mne/preprocessing/tests/test_xdawn.py::test_xdawn_decoding_performance - ImportError: cannot import name 'validate_data' from 'sklearn.utils.validation' (/home/runner/micromamba/envs/mne/lib/python3.10/site-packages/sklearn/utils/validation.py)
FAILED mne/tests/test_docstring_parameters.py::test_docstring_parameters - ImportError: cannot import name 'validate_data' from 'sklearn.utils.validation' (/home/runner/micromamba/envs/mne/lib/python3.10/site-packages/sklearn/utils/validation.py)
FAILED mne/tests/test_docstring_parameters.py::test_documented - ImportError: cannot import name 'validate_data' from 'sklearn.utils.validation' (/home/runner/micromamba/envs/mne/lib/python3.10/site-packages/sklearn/utils/validation.py)

@larsoner larsoner marked this pull request as ready for review July 3, 2025 22:40
drammock
drammock approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable. There was a segfault in ubuntu conda 3.12 CI job, restarted.

@larsoner larsoner enabled auto-merge (squash) July 4, 2025 16:23
@larsoner larsoner merged commit d970efb into mne-tools:main Jul 5, 2025
32 checks passed
@larsoner larsoner deleted the sklearn branch July 5, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drammock drammock drammock approved these changes

@agramfort agramfort Awaiting requested review from agramfort agramfort is a code owner

@jasmainak jasmainak Awaiting requested review from jasmainak jasmainak is a code owner

Assignees
No one assigned
Labels
no-changelog-entry-needed
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.

need to specify min version of scikit-learn
2 participants
@larsoner @drammock