properly closing maestro sessions #2391
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeduartea
commented
Mar 22, 2025
| @@ -70,13 +71,16 @@ object MaestroSessionManager { | |||
| ) | |||
| val sessionId = UUID.randomUUID().toString() | |||
|
|
|||
| val isHeartbeatActive = AtomicBoolean(true) //Controlling heartbeat with an atomic bool | |||
There was a problem hiding this comment.
I'm not really sure about wether this is a good way to handle this, so feedbacks appreciated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Noticed that the close function in maestroSessionManager wasn't really closing sessions. That happened because the SessionStore creates the session again with the heartbeat.
To handle this correctly we need to cancel the hearbeat before closing the session
Testing
Issues fixed