Skip to content

[MA 3225] maestro refactor #2444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

amanjeetsingh150
Copy link
Collaborator

Proposed changes

  1. Removed deviceId from IOSDevice interface: This property was unused in implementations like XCTestIOSDevice, so it's been removed to simplify the interface.
  2. Cleaned up unused methods: Removed isKeyboardVisible from both Maestro and IOSDriver, as it’s no longer used in any flow.
  3. Stopped sending appIds in driver requests:
  • For commands like view hierarchy, input text, and erase text, we no longer send appIds.
  • The server still accepts them to maintain backward compatibility with production clients but this will eventually be removed from the server as well.
  1. Simplified XCTestIOSDevice constructor: listApps is no longer passed during construction since it’s unused.
  2. Removed deprecated swipeV1 implementation: This version required an active app ID and is no longer necessary. All usage has been migrated.

Testing

Issues fixed

Copy link

linear bot commented Apr 25, 2025

Copy link

Make sure to run ./maestro-ios-xctest-runner/build-maestro-ios-runner.sh with every swift change

@amanjeetsingh150 amanjeetsingh150 force-pushed the MA-3225-maestro-refactor branch from c6995dc to 464acfb Compare April 25, 2025 09:04
@amanjeetsingh150 amanjeetsingh150 marked this pull request as ready for review April 28, 2025 09:09
@amanjeetsingh150 amanjeetsingh150 requested a review from herval April 28, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant