[proposal] make run flows cancellable if coroutine scope is cancelled #2488
Conversation
| logger.info("Flow cancelled, skipping command...") | ||
| onCommandSkipped(index, command) | ||
| return@forEachIndexed | ||
| } |
There was a problem hiding this comment.
Let's say if coroutine context is cancelled where should we be releasing resources that got acquired during execution?
There are bunch already that could be acquired: There is insights listener, leaveScope on jsEngine, there is global screenRecording field which would have risk of just keep running.
There was a problem hiding this comment.
Let's say if coroutine context is cancelled where should we be releasing resources that got acquired during execution?
on the same place they get released without cancellation?
is there anything on this PR not being released with this change?
There was a problem hiding this comment.
hmm I see some funkiness with the jsEngine thing being a lateinit. I'll keep it being initialized even if the routine is cancelled to avoid some unexpected behavior
There was a problem hiding this comment.
verified that screenrecording.close will be called regardless of cancellation, so that one seems safe?
|
|
||
| commands | ||
| .forEachIndexed { index, command -> | ||
| if (!coroutineContext.isActive) { |
There was a problem hiding this comment.
I'm thinking how this should look like for cli, should there be any controls there? I believe not useful, because users usually press control + c to break from flows.
Although I'm not sure about CI
There was a problem hiding this comment.
ctrl+c kills the entire Java process, so it's not gonna impact any of this. Coroutine cancellation is for when you have a process still running and you want to cancel it
herval
force-pushed
the
cancellation-support
branch
from
7163212 to
924909b
Compare
The goal here is to make a Maestro Orchestra coroutine-cancellable - if the context where it's running is cancelled, it'll skip heavy setup steps (eg initializing the js engine). It'll still go through all the commands on the flow, but marking them all as SKIPPED instead of executing them.