mcp: validate required fields in ImageContent and AudioContent #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up related to #91 (though not requiring it).
ImageContent
andAudioContent
now return errors when required fields are missing during JSON marshaling, matching TypeScript schema requirements. This follows the pattern in ResourceContents in the same file.ImageContent
requiresdata
andmimeType
fields.AudioContent
requiresdata
andmimeType
fields.Alternatives:
Another way to go about this would be to not omit required attrs when the values are blank. At least we would produce blank values which is preferable to omitted keys (which cause the typescript sdk client to fail rather than report a tool call malfunction to the user).