Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137
In this PR, I add:
ClientTest
Motivation and Context
To support the new elicitation feature of the 2025-06-18 protocol version.
How Has This Been Tested?
I added two tests in
ClientTest
. The tests are not extensive yet as I only check:Maybe should I add some more tests? Please advise me.
Breaking Changes
N/A
Types of changes
Checklist
Additional context
I was not sure whether to add the tests to
ClientTest
orServerTest
. (It seems to me that the tests should be divided by feature and not by client/server side, as most features involve both client and server, but I respected how it is done today.)I was not sure whether to add a method to
Client
to register an elicitation handler (i.e. wrap thesetRequestHandler(...)
call). Please advise me on what you think is best. (If that is best to add a wrapper method, maybe this can be implemented as a follow-up?)The
CreateElicitationRequest.RequestedSchema
class I introduced is duplicated fromTool.Input
. Maybe that should be factored-out in aJsonSchema
top-level class intypes.kt
. I was not sure you would approve that, so I did not factor it out. Please tell me if you'd prefer I factor that out. (The support for the new Tool output schema in the latest protocol version will also need the same type.)