Skip to content

docs: add clearer annotations in model.rs #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

docs: add clearer annotations in model.rs #284

merged 1 commit into from
Jun 25, 2025

Conversation

jokemanfire
Copy link
Collaborator

Notion

Motivation and Context

The model.rs code is large enough ,we should add notion for greater code struct.

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@github-actions github-actions bot added the T-core Core library changes label Jun 25, 2025
@jokemanfire jokemanfire requested a review from 4t145 June 25, 2025 09:48
@jokemanfire jokemanfire changed the title docs: add notion clear in model.rs docs: add clearer annotations in model.rs Jun 25, 2025
4t145
4t145 approved these changes Jun 25, 2025
View reviewed changes
Copy link
Collaborator

@4t145 4t145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@4t145 4t145 merged commit 09caeb3 into modelcontextprotocol:main Jun 25, 2025
9 of 11 checks passed
@github-actions github-actions bot mentioned this pull request Jul 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4t145 4t145 4t145 approved these changes

Assignees
No one assigned
Labels
T-core Core library changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jokemanfire @4t145