Skip to content

Add MCPReview #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 30, 2025
Merged

Add MCPReview #1981

merged 4 commits into from
Jun 30, 2025

Conversation

henroger
Copy link
Contributor

@henroger henroger commented May 31, 2025

Description

Server Details

  • Server:
  • Changes to:

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Additional context

@henroger henroger changed the title Update README.md Add MCPReview May 31, 2025
@olaservo olaservo added add-community-server This pull request adds a link to a community-created server. and removed add-community-server This pull request adds a link to a community-created server. labels Jun 5, 2025
@olaservo
Copy link
Member

olaservo commented Jun 9, 2025

Hi @henroger thanks for the PR. I took a look at the link and I don't see a way to view or submit reviews as mentioned in the description you added here. Could you share more info on whether this is actually accurate?

@olaservo olaservo added the waiting for submitter Waiting for the submitter to provide more info label Jun 9, 2025
@henroger
Copy link
Contributor Author

Hi @henroger thanks for the PR. I took a look at the link and I don't see a way to view or submit reviews as mentioned in the description you added here. Could you share more info on whether this is actually accurate?

Hi @olaservo we do have review score and comments now and will be adding AI MCP review report soon.

@olaservo olaservo removed the waiting for submitter Waiting for the submitter to provide more info label Jun 13, 2025
olaservo
olaservo previously approved these changes Jun 13, 2025
Copy link
Member

@olaservo olaservo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will grab this in the next round of Resource section updates.

@olaservo olaservo added the add-community-resource This pull request adds a link to a resource in the Readme. label Jun 13, 2025
@henroger
Copy link
Contributor Author

@olaservo hi, I am sorry to reactivate this PR again, just wondering is this ever going to be merged?

@olaservo olaservo merged commit fca70ec into modelcontextprotocol:main Jun 30, 2025
@olaservo
Copy link
Member

olaservo commented Jun 30, 2025

Hi @henroger sorry and thanks for the ping, this one was going to go through with an aggregated PR but I decided to merge the non-server PRs separately instead. This has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-community-resource This pull request adds a link to a resource in the Readme.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants