Skip to content

Implement client protocol version negotiation in server initialization #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2025
Merged

Implement client protocol version negotiation in server initialization #107

merged 3 commits into from
May 7, 2025

Conversation

mattt
Copy link
Contributor

@mattt mattt commented May 7, 2025

Resolves #106

@mattt mattt changed the title Implement client version negotiation in server initialization Implement client protocol version negotiation in server initialization May 7, 2025
@mattt
Copy link
Contributor Author

mattt commented May 7, 2025 •
edited
Loading

Just tested this against real-world clients, and this fixed the issues I was running into previously. Merging this in now and cutting a new patch release. 1

Footnotes

  1. https://github.com/modelcontextprotocol/swift-sdk/pull/107/commits/eb683955c5a479e8b7d0d88ca8d0aaf4b7c73763 walks back a change that would otherwise make this a SemVer minor change. I intend to make these public in a follow-up ↩

@mattt mattt merged commit 720a810 into main May 7, 2025
6 checks passed
@mattt mattt deleted the mattt/version-negotiation branch May 7, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server doesn't negotiate protocol version with connecting clients
1 participant
@mattt