-
Notifications
You must be signed in to change notification settings - Fork 55
Add StdioTransport
support for Linux with musl
#63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mattt
wants to merge
11
commits into
main
Choose a base branch
from
mattt/musl-linux
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Replace os checks with canImport
StdioTransport
support for Linux with musl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #61
The Swift Static Linux SDK allows Swift code to be built as a fully statically linked executables. Notably, this allows a package to be usable in executables built for Alpine Linux, which uses musl instead of glibc.
The actual implementation (f3f4cfd) is, theoretically, straightforward — just another conditional compilation
#canImport
. The tricky part has been testing this in CI. Because Swift isn't currently supported on Alpine Linux, we need to build an executable with the Swift Static Linux SDK in a separate job. However, this approach fails because of an apparent lack of support for Swift Testing:As a workaround, we can create an example binary executable and run that as a substitute for our test suite. But that's more than I want to bite off right now, so I'll convert this to draft for now.