Skip to content

Resume NetworkTransfer with EOF instead of throwing error when no data is received #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

Resume NetworkTransfer with EOF instead of throwing error when no data is received #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Sources/MCP/Base/Transports/NetworkTransport.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,11 @@ import struct Foundation.Data
while isConnected && !Task.isCancelled {
do {
let newData = try await receiveData()
// Check for EOF (empty data)
if newData.isEmpty {
logger.info("Connection closed by peer (EOF).")
break // Exit loop gracefully
}
buffer.append(newData)

// Process complete messages
Expand Down Expand Up @@ -219,8 +224,8 @@ import struct Foundation.Data
} else if let content = content {
continuation.resume(returning: content)
} else {
continuation.resume(
throwing: MCPError.internalError("No data received"))
// EOF: Resume with empty data instead of throwing an error
continuation.resume(returning: Data())
}
}
}
Expand Down