Skip to content

Fix ui #3903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2025
Merged

Fix ui #3903

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b84e33
fix ui
tastelikefeet Apr 15, 2025
4bb095a
teset passed
tastelikefeet Apr 16, 2025
3f22690
revert code
tastelikefeet Apr 16, 2025
bc27c2e
fix
tastelikefeet Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert code
  • Loading branch information
@tastelikefeet
tastelikefeet committed Apr 16, 2025
commit 3f2269091867a8196fe722cdf688feca74642837
9 changes: 1 addition & 8 deletions swift/ui/llm_train/llm_train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,12 +150,6 @@ class LLMTrain(BaseUI):
'en': 'Extra env vars'
},
},
'resume_train': {
'label': {
'zh': '继续训练',
'en': 'Resume train'
},
},
'use_ddp': {
'label': {
'zh': '使用DDP',
Expand Down Expand Up @@ -228,7 +222,6 @@ def do_build_ui(cls, base_tab: Type['BaseUI']):
gr.Dropdown(elem_id='torch_dtype', scale=4)
gr.Checkbox(elem_id='use_liger_kernel', scale=4)
gr.Checkbox(elem_id='use_ddp', value=False, scale=2)
gr.Checkbox(elem_id='resume_train', value=False, scale=2)
gr.Textbox(elem_id='ddp_num', value='2', scale=4)
Hyper.build_ui(base_tab)
Runtime.build_ui(base_tab)
Expand Down Expand Up @@ -283,7 +276,7 @@ def update_runtime(cls):

@classmethod
def train(cls, *args):
ignore_elements = ('logging_dir', 'more_params', 'train_stage', 'envs', 'resume_train')
ignore_elements = ('logging_dir', 'more_params', 'train_stage', 'envs')
default_args = cls.get_default_value_from_dataclass(RLHFArguments)
kwargs = {}
kwargs_is_list = {}
Expand Down
Loading