Skip to content

[megatron] Support Qwen3 #3995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 26, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update
  • Loading branch information
Jintao-Huang committed Apr 26, 2025
commit da2efd4358a20dcb7194f2b6a539b2087133b7a8
3 changes: 2 additions & 1 deletion swift/llm/train/sft.py
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,8 @@ def _stat_dataset(self, dataset: HfDataset):
def _encode_dataset(self, train_dataset, val_dataset):
template = self.template
args = self.args
self._save_val_dataset(args.output_dir, val_dataset)
output_dir = getattr(args, 'output_dir', None) or getattr(args, 'save')
self._save_val_dataset(output_dir, val_dataset)
is_grpo = hasattr(args, 'rlhf_type') and args.rlhf_type == 'grpo'
predict_with_generate = getattr(args, 'predict_with_generate', False)
if not is_grpo:
Expand Down