Skip to content

[grpo] fix multi modal doc #4124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2025
Merged

[grpo] fix multi modal doc #4124

merged 2 commits into from
May 11, 2025

Conversation

hjh0119
Copy link
Collaborator

@hjh0119 hjh0119 commented May 8, 2025

PR type

  • Bug Fix
  • New Feature
  • Document Updates
  • More Models or Datasets Support

PR information

Unified length control logic for clarity
Fixed incorrect parameter assignment: max_completion_length was mistakenly set to vllm_max_model_len

Experiment results

Paste your experiment result here(if needed).

@hjh0119 hjh0119 changed the title Fix grpo multi modal doc [grpo] fix multi modal doc May 11, 2025
@hjh0119 hjh0119 merged commit 890e5a3 into modelscope:main May 11, 2025
1 check passed
@hjh0119 hjh0119 deleted the fix-mmdoc branch May 11, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants