[grpo] fix labels pop and peftmodel parameter check #4136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jintao-Huang
approved these changes
May 8, 2025
tastelikefeet
added a commit
to tastelikefeet/swift
that referenced
this pull request
May 9, 2025
* main: Support init parameters (modelscope#4141) Feature freezing/activating parameters via regex (modelscope#4143) grpo code reward by judge0 (modelscope#4140) [megatron] support max_epochs (modelscope#4125) [grpo] fix labels pop and peftmodel parameter check (modelscope#4136) # Conflicts: # docs/source/Instruction/命令行参数.md # docs/source_en/Instruction/Command-line-parameters.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR type
PR information
in some case, model forward with labels will cause logits None, we pop labels here
for peft model, inspect inner model to save memory with logits_to_keep parameter(super)
Experiment results
Paste your experiment result here(if needed).